build: resolve npm audit advisories - #14
Open
antobinary wants to merge 3 commits into
Open
antobinary wants to merge 3 commits into
antobinary wants to merge 3 commits into
Conversation
Add an `engines` floor of Node >= 22 to package.json and mirror it into package-lock.json, and bump @types/node to ^24.13.3 so the typings match the runtime the plugin is built with. Move CI onto Node 24 (was Node 20). Raise the Debian Build-Depends floor to nodejs (>= 22) and install Node 24 from NodeSource when building the package.
@types/node was listed in both dependencies and devDependencies, and the two had drifted apart before they were aligned on ^24.13.3. It supplies build-time typings only, so keep the devDependencies entry and drop the duplicate. npm already resolved it as a dev-only package, so installs are unaffected; this just makes package.json say what npm was already doing.
Run npm audit fix, then take the two major upgrades it could not apply on its own: copy-webpack-plugin 12 -> 14 and webpack-dev-server 4 -> 6. Between them these clear the shell-quote and websocket-driver criticals and the serialize-javascript, sockjs and uuid advisories. Everything changed here is build tooling; none of it ships in the bundle. webpack-dev-server 6 was verified beyond a successful build by starting the dev server and confirming the custom devServer.app route for /manifest.json still answers 200. Pin watch back to ^0.13.0, the version the other repos already use. Its 1.x line pulls exec-sh and a prototype-pollution advisory in merge, and npm's own resolution for those advisories is 0.13.0. It only backs the lint:watch helper script.
imdt-claudiop
approved these changes
Sep 14, 2026
imdt-claudiop
left a comment
imdt-claudiop
left a comment
There was a problem hiding this comment.
Approved.
Same remediation as bigbluebutton/bbb-plugin-picture-in-picture#45, which is already merged: copy-webpack-plugin 12 to 14 and webpack-dev-server to 6.
Verified on Node 24.9.0:
npm auditon the base branch reports 32 vulnerabilities (17 high, 2 critical), and 0 on this branchnpm installclean, no package-lock.json driftnpx tscandnpm run lintpassnpm run build-bundleproducesdist/DecreaseVolumeOnSpeak.jsnpm startstill serves. This repo's webpack.config.js already usessetupMiddlewares, so the dev-server major upgrade needs no config change here, unlike the reference PR which had to migrate it.
|
This pull request has conflicts ☹ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Npm audit fixes
Applied in two passes:
npm audit fix— every non-breaking resolution. This alone cleared bothcriticals (
shell-quote,websocket-driver) and most highs.copy-webpack-plugin^12.0.2->^14.0.0(clearsserialize-javascript)webpack-dev-server^4.15.1->^6.0.0(clearssockjs,uuid, and thewebpack-dev-server source-disclosure advisory)
Scope
Everything changed here is build tooling. None of it ships in the bundle — the
plugin deploys a single bundled JS file, and these packages exist only to
produce it. The value is build-time supply-chain integrity rather than a runtime
exposure.
Testing
Against Node 24.20.0:
npm ci— PASSnpx tsc— PASSnpm run lint— PASSnpm run build-bundle— PASSnpm audit— 0 vulnerabilitieswebpack-dev-server6 is a major bump with breaking config changes, and asuccessful production build does not exercise the dev-server path at all. It was
verified separately by starting the dev server and confirming the custom
setupMiddlewares/devServer.app.get('/manifest.json')route still answers200 with the correct body. That API survived the major unchanged, so
npm run startstill works as before.Notes for review
The
package-lock.jsondiff is large because the whole dev dependency tree wasre-resolved.
package.jsonis the meaningful diff: two version bumps.