Enable type-aware Oxlint rules and compiler diagnostics - #1463
Merged
Merged
Conversation
kemboi22
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable type-aware correctness rules and TypeScript compiler diagnostics in the shared Oxlint configuration, backed by pinned
oxlint-tsgolint. Lint commands now check types, so remove the standalonetypecheckscript and run Vitest directly from the test commands. Verification runs Oxlint once before the build and tests. Build and watch commands retaintscfor JavaScript and declaration output.Reference
tsconfig.test.jsonfrom the root project so Oxlint discovers tests, helpers, and the Vitest config. Keep its Bundler module resolution separate from the production Node16 configs. Fix newly reported promise and string-conversion issues, preserve detached background work, and disableunbound-methodonly in test files where Vitest inspects mock methods.Validation on the branch rebased onto
main:pnpm install --frozen-lockfilepnpm verify:bail: lint, formatting, both builds, and coverage passed; 526 tests passed and 2 skipped.any, and floating promises are rejected in server/client source, server/client tests, nested tests, test helpers, and the Vitest config. All probes were removed.Local lint/type-check benchmark (macOS arm64, Node 22.22.2, TypeScript 6.0.3): one warmup per mode and five alternating measured runs on the same checkout. The old Oxlint config plus
tsc --noEmit -p tsconfig.test.jsontook a median 1.516s (tsc alone: 1.431s); the new type-aware Oxlint command took 0.577s. This saves about 0.94s / 62% for this step while adding type-aware lint rules. Measurements use the local executables, excluding pnpm startup, Prettier, builds, and tests.tscstill handles builds; coverage remains unchanged in this PR.