bugfix: deliver breadcrumbs to native crash reports - #392
Merged
Conversation
melekr
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Breadcrumbs never reached native crash reports: nothing pushed the chunk files or
breadcrumbs.lastIdafter init, and rotation never triggered because exact-boundary splits were dropped.Changes
FileChunkSink.ts: adds anonFilesChangehook, fires it whenever a chunk file is created.FileBreadcrumbsStorage.ts: forwards the hook with the current last breadcrumb id.BacktraceClient.ts: pushes the attachment list andbreadcrumbs.lastIdto the native crash reporter on every chunk creation.combinedChunkSplitter.ts: keeps empty second chunks so exact-boundary splits are not dropped.nativeBreadcrumbPropagationTests.spec.ts: new, asserts rotated files reach native, chunk 0 drops out of the last push, pushed id advances.combinedChunkSplitter.spec.ts: new, covers splitter combining and the exact-boundary split.ref: BT-7501, BT-7564