Preserve existing getObject files - #7353
Merged
Merged
Conversation
…the download fails before writing
dagnir
approved these changes
Sep 4, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Sep 4, 2026
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
FileAsyncResponseTransformerdeleted the destination wheneverFailureBehavior.DELETEwas configured, even when the current request attempt failed before opening the file. WithCREATE_NEW, this could delete a pre-existing file and allow a retry to silently replace it.Modifications
This change resets file-channel state for each attempt, clears it during failure cleanup, and deletes the destination only when the current attempt successfully opened it. Existing files are preserved when opening fails or the request fails before writing. Partial output is still deleted after a successful open when
FailureBehavior.DELETEis configured.Behavior change: an async download with
CREATE_NEWonto an existing destination now surfacesFileAlreadyExistsExceptioninstead of deleting the file and letting the retry overwrite it.Callers that intentionally require replacement behavior should use
getObject(request, AsyncResponseTransformer.toFile(path, FileTransformerConfiguration.defaultCreateOrReplaceExisting())).Testing
Added unit tests
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License