Skip to content

Support leading-dot suffixes in NO_PROXY - #7346

Open
afarber wants to merge 1 commit into
aws:masterfrom
afarber:5573-no-proxy-wildcards
Open

Support leading-dot suffixes in NO_PROXY#7346
afarber wants to merge 1 commit into
aws:masterfrom
afarber:5573-no-proxy-wildcards

Conversation

@afarber

@afarber afarber commented Sep 3, 2026

Copy link
Copy Markdown

Motivation and Context

Fixes #5573.

NO_PROXY commonly uses a leading-dot domain suffix such as .company.internal. The SDK accepted *.company.internal, but not the equivalent leading-dot form.

Modifications

  • Normalize leading-dot suffixes in the NO_PROXY environment variable to the existing wildcard form.
  • Add parsing and Apache proxy-route tests.
  • Document leading-dot suffix support in the HTTP client proxy configuration Javadocs.
  • Add a changelog entry.

Testing

Ran the affected utility tests:

./mvnw -pl :utils -Dtest=SdkHttpUtilsTest,ProxyConfigurationTest test

Ran the Apache proxy tests:

./mvnw -pl :apache-client -am -Dcheckstyle.skip=true -Dspotbugs.skip=true -Dtest=ApacheHttpProxyTest,SdkProxyRoutePlannerTest -Dsurefire.failIfNoSpecifiedTests=false test

Both commands succeeded.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

License

  • I confirm that this pull request can be released under the Apache 2 license

@afarber
afarber requested a review from a team as a code owner September 3, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NO_PROXY environment variable not handling wildcards properly

1 participant