Fix flaky test pause_fileChanged_resumeShouldStartFromBeginning - #7341
Merged
Conversation
zoewangg
reviewed
Sep 3, 2026
S-Saranya1
force-pushed
the
somepal/fix-flaky-preview-build-tests
branch
from
September 3, 2026 23:01
741026c to
ba6ad41
Compare
zoewangg
approved these changes
Sep 4, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to Branch Protection failures
Sep 4, 2026
You're not authorized to push to this branch. Visit "About protected branches" for more information.
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
pause_fileChanged_resumeShouldStartFromBeginningis flaking in preview builds (parameterized cases [3] and [4] - cross-TM resume). After file change, the transfer manager starts a fresh single-part upload, but the progress tracker does not populatetotalBytes, causingExpecting Optional to contain a value but it was empty.Modifications
Replaced the assertion on
progress().snapshot().totalBytes()with a SHA-256 checksum comparison of the local bytes against the S3 object content, following the existing pattern inS3TransferManagerUploadIntegrationTest.Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License