Skip to content

Fix flaky test pause_fileChanged_resumeShouldStartFromBeginning - #7341

Merged
S-Saranya1 merged 1 commit into
masterfrom
somepal/fix-flaky-preview-build-tests
Sep 5, 2026
Merged

Fix flaky test pause_fileChanged_resumeShouldStartFromBeginning#7341
S-Saranya1 merged 1 commit into
masterfrom
somepal/fix-flaky-preview-build-tests

Conversation

@S-Saranya1

@S-Saranya1 S-Saranya1 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Motivation and Context

pause_fileChanged_resumeShouldStartFromBeginning is flaking in preview builds (parameterized cases [3] and [4] - cross-TM resume). After file change, the transfer manager starts a fresh single-part upload, but the progress tracker does not populate totalBytes, causing Expecting Optional to contain a value but it was empty.

Modifications

Replaced the assertion on progress().snapshot().totalBytes() with a SHA-256 checksum comparison of the local bytes against the S3 object content, following the existing pattern in S3TransferManagerUploadIntegrationTest.

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@S-Saranya1
S-Saranya1 requested a review from a team as a code owner September 2, 2026 21:36
@S-Saranya1
S-Saranya1 requested a review from zoewangg September 2, 2026 23:43
@S-Saranya1
S-Saranya1 force-pushed the somepal/fix-flaky-preview-build-tests branch from 741026c to ba6ad41 Compare September 3, 2026 23:01
@S-Saranya1
S-Saranya1 requested a review from zoewangg September 3, 2026 23:06
@S-Saranya1
S-Saranya1 added this pull request to the merge queue Sep 4, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to Branch Protection failures Sep 4, 2026
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@S-Saranya1
S-Saranya1 added this pull request to the merge queue Sep 4, 2026
Merged via the queue into master with commit 08f6635 Sep 5, 2026
18 of 19 checks passed
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants