docs: add ADC CI/CD guidance - #560
Open
kayx23 wants to merge 4 commits into
Open
Conversation
|
Warning Review limit reached
On-demand reviews are free for the next 25 days. After that, they cost $0.25 per reviewed file. Or wait 50 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The previous CI example treated validate, empty diffs, and container `--user` as always safe. Local ADC 0.29.0 runs against APISIX 3.13 showed those assumptions fail, so the guide now matches actual command and image behavior before review.
kayx23
marked this pull request as ready for review
August 26, 2026 06:30
ADC's own e2e suite gates validate at 3.17.0. Rechecking 3.18.0 showed validate succeeding and a minimal service round-tripping to an empty diff, so the CI guide should not treat 3.13 Admin API gaps as current APISIX behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api7/adccontainer helper, including why the image entrypoint must be overridden, why the host user cannot be substituted, and that uid65532must be able to writediff.yaml.adc validateavailability: API7 Enterprise 3.9.10+, Apache APISIX only when/apisix/admin/configs/validateexists.adc diffexits 0 when it finds differences, and that dumped files can include unscoped emptyglobal_rulesandplugin_metadatamaps.lint && validate && diff && syncblock with a pointer to the production model, and order the docs index as workflow → resource IDs → label selector → CI/CD.Why
The existing workflow documentation explained individual commands but not a safe production delivery process. Operators need explicit guidance about destructive synchronization scope, credential exposure, plan/deploy consistency, concurrent jobs, partial failure, and recovery.
Local verification against ADC 0.29.0 and Apache APISIX 3.13 also showed that treating
validateand a post-sync emptydiff.yamlas universal steps is incorrect for many APISIX versions.User impact
Readers now have one end-to-end operational model:
diff.yamlwithout applying that fileThe guide supports both Apache APISIX and API7 Enterprise while retaining the warning that the APISIX backend is experimental and often normalizes defaults such as route
priorityand upstreamhash_on.Validation
WORKDIR=/home/nonroot, uid 65532,/home/nonrootmode 0700), label injection, non-atomicsync, anddiff.yamlwritergit diff --check) and verified relative documentation linksapi7/adc:0.29.0against disposable Apache APISIX 3.13.0adc validatefails on APISIX 3.13.0 (missing/apisix/admin/configs/validate) and that a minimal service/route does not round-trip todiff.yaml: []because APISIX fills defaultsSummary by CodeRabbit