Disable vendor extension types on the XML-RPC servlet - #171
Open
snoopdave wants to merge 1 commit into
Open
Conversation
Roller's XML-RPC API uses only the standard XML-RPC value types; the library's vendor extension types are unused and are switched off. The endpoint is also gated on webservices.enableXmlRpc so a disabled service is not reachable and does not read request bodies. Adds XmlRpcExtensionTypeTest, which checks the shipped configuration and that ordinary calls still parse. Claude-Session: https://claude.ai/code/session_01A1fhY1E2PCFU6UAPXu2WtV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The XML-RPC servlet is configured to accept the library's non-standard vendor
extension types, which Roller does not use, and its mapped endpoint answers
requests even when the XML-RPC feature is switched off. This change turns the
extensions off and makes the disabled-by-default toggle close the endpoint.
What changed
enabledForExtensions=false, or drop theenabling servlet init-param), since Roller uses only the standard XML-RPC
value types.
webservices.enableXmlRpc, so a disabled API isclosed at the endpoint instead of relying on per-handler checks.
Tests
the endpoint.
XML-RPC call reaches its handler.