Check weblog permission in XML-RPC Blogger/MetaWeblog handlers - #164
Open
snoopdave wants to merge 3 commits into
Open
Check weblog permission in XML-RPC Blogger/MetaWeblog handlers#164snoopdave wants to merge 3 commits into
snoopdave wants to merge 3 commits into
Conversation
A caller without POST permission now scans at most a fixed number of entries rather than the whole weblog before the in-memory permission filter runs, and a non-positive count returns nothing. Claude-Session: https://claude.ai/code/session_01A1fhY1E2PCFU6UAPXu2WtV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Blogger and MetaWeblog XML-RPC handlers are Roller's legacy remote-publishing
API. This change makes them apply the same per-weblog and per-entry permission
model that the rest of Roller uses, so a caller is authorized against the weblog
or entry an operation actually touches.
What changed
ADMIN/EDIT_DRAFT/POST, or entry-level write permission) to the weblog or entry actuallytouched.
getUserInforeturns only the authenticated user;getUsersBlogsreturns onlyAPI-enabled member weblogs.
Tests
Table-driven integration suite over every exposed handler method: authorized
member, authenticated non-member, insufficient role, disabled user/weblog/API,
draft-to-published transition, filtered recent posts, category/weblog mismatch,
and foreign/absent resource identifiers.