Conversation
lordgamez
force-pushed
the
MINIFICPP-2852
branch
from
September 14, 2026 11:39
c04e43f to
d5f711e
Compare
lordgamez
force-pushed
the
MINIFICPP-2854
branch
from
September 14, 2026 11:45
8c249f6 to
62491ef
Compare
lordgamez
marked this pull request as ready for review
September 14, 2026 11:45
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Execution and reporting paths can fail or silently produce incomplete or misleading benchmark results.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds tooling to benchmark MiNiFi C++ FlowFile and content repository implementations.
Changes:
- Adds single and batch benchmark runners with multiple workload modes.
- Collects CPU, memory, repository-size, and throughput metrics.
- Generates aggregated HTML reports and documents usage.
File summaries
| File | Description |
|---|---|
run_benchmark.py |
Runs workloads and collects metrics. |
run_batch.py |
Executes repeated repository combinations. |
generate_report.py |
Generates aggregate HTML reports. |
resources/get_config.json |
Defines GetFile benchmark flow. |
resources/generate_config.json |
Defines GenerateFlowFile benchmark flow. |
requirements.txt |
Declares Python dependencies. |
README.md |
Documents benchmark workflows. |
results/.gitignore |
Excludes generated results. |
Review details
Suppressed comments (1)
benchmarks/repository_benchmark/run_benchmark.py:222
- As in the startup waiter, this newly returned docker-py
Containerhas not been reloaded, soattrs["Created"]is not guaranteed to exist and burst runs can fail immediately withKeyError. Start from the beginning of this container's logs instead.
since = datetime.fromisoformat(container.attrs["Created"])
- Files reviewed: 8/8 changed files
- Comments generated: 6
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lordgamez
force-pushed
the
MINIFICPP-2854
branch
3 times, most recently
from
September 14, 2026 15:20
a6d1495 to
9313164
Compare
lordgamez
force-pushed
the
MINIFICPP-2854
branch
from
September 14, 2026 15:30
9313164 to
4617e99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MINIFICPP-2854
Report generation and README was generated using Claude Code.
Depends on #2203
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.