Skip to content

Fix pipe historical extraction when device metadata is unavailable #18541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Caideyipi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix pipe historical extraction when device metadata is unavailable #18541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...db/pipe/source/dataregion/historical/PipeHistoricalDataRegionTsFileAndDeletionSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,7 +1012,7 @@ private boolean mayTsFileResourceOverlappedWithPattern(final TsFileResource reso
.getDeviceIsAlignedMapFromCache(resource.getTsFile(), false);
deviceSet =
Objects.nonNull(deviceIsAlignedMap) ? deviceIsAlignedMap.keySet() : resource.getDevices();
} catch (final IOException e) {
} catch (final IOException | RuntimeException e) {
LOGGER.warn(
DataNodePipeMessages.PIPE_FAILED_TO_GET_DEVICES_FROM_TSFILE_1,
pipeName,
Expand Down
26 changes: 26 additions & 0 deletions ...ipe/source/dataregion/historical/PipeHistoricalDataRegionTsFileAndDeletionSourceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,14 @@
import org.apache.iotdb.commons.pipe.config.constant.SystemConstant;
import org.apache.iotdb.commons.pipe.config.plugin.configuraion.PipeTaskRuntimeConfiguration;
import org.apache.iotdb.commons.pipe.config.plugin.env.PipeTaskSourceRuntimeEnvironment;
import org.apache.iotdb.commons.pipe.datastructure.pattern.PrefixTreePattern;
import org.apache.iotdb.commons.pipe.datastructure.resource.PersistentResource;
import org.apache.iotdb.commons.pipe.event.ProgressReportEvent;
import org.apache.iotdb.commons.utils.FileUtils;
import org.apache.iotdb.db.pipe.consensus.ReplicateProgressDataNodeManager;
import org.apache.iotdb.db.storageengine.dataregion.tsfile.TsFileResource;
import org.apache.iotdb.db.storageengine.dataregion.tsfile.TsFileResourceStatus;
import org.apache.iotdb.db.storageengine.dataregion.tsfile.timeindex.FileTimeIndex;
import org.apache.iotdb.pipe.api.customizer.parameter.PipeParameterValidator;
import org.apache.iotdb.pipe.api.customizer.parameter.PipeParameters;
import org.apache.iotdb.pipe.api.event.Event;
Expand Down Expand Up @@ -146,6 +148,30 @@ public void testSupplyDoesNotSwallowNonSkippedNullTsFileEvent() throws Exception
}
}

@Test
public void testMissingTsFileResourceDoesNotBlockHistoricalExtraction() throws Exception {
final PipeHistoricalDataRegionTsFileAndDeletionSource source =
new PipeHistoricalDataRegionTsFileAndDeletionSource();
final File tempDir = Files.createTempDirectory("pipeHistoricalMissingResource").toFile();

try {
final TsFileResource resource = createTsFileResource(tempDir, "missing-resource.tsfile");
resource.setTimeIndex(new FileTimeIndex());
setPrivateField(source, "pipeName", "pipe");
setPrivateField(source, "dataRegionId", 1);
setPrivateField(source, "treePattern", new PrefixTreePattern("root.**"));

final Method method =
PipeHistoricalDataRegionTsFileAndDeletionSource.class.getDeclaredMethod(
"mayTsFileResourceOverlappedWithPattern", TsFileResource.class);
method.setAccessible(true);

Assert.assertTrue((Boolean) method.invoke(source, resource));
} finally {
FileUtils.deleteFileOrDirectory(tempDir);
}
}

@Test
public void testSupplyRetriesSameTsFileAfterEventCreationFailure() throws Exception {
final TestablePipeHistoricalDataRegionTsFileAndDeletionSource source =
Expand Down
Loading