Skip to content

CI: Skip link-check on external URIs - #3966

Merged
kevinjqliu merged 2 commits into
apache:mainfrom
rambleraptor:markdown-link-check-retry-429
Sep 14, 2026
Merged

kevinjqliu merged 2 commits into
apache:mainfrom
rambleraptor:markdown-link-check-retry-429

Conversation

@rambleraptor

@rambleraptor rambleraptor commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Rationale for this change

The Ray docs are consistently throwing 429s at GitHub Actions, which is causing our Markdown Link checker to consistently fail.

At @kevinjqliu's suggestion, I'm adding disable lines to external URIs in the docs. Additionally, I've added in some info on AGENTS.md so that future external URIs (written by bots) will hopefully get these in the future.

Are these changes tested?

CI should remain passing.

Are there any user-facing changes?

@rambleraptor
rambleraptor force-pushed the markdown-link-check-retry-429 branch from e7b51b6 to 814c3b6 Compare September 14, 2026 20:40
@rambleraptor rambleraptor changed the title CI: Retry rate-limited links in markdown-link-check CI: Allow 429 success in markdown-link-check Sep 14, 2026
@rambleraptor

Copy link
Copy Markdown
Collaborator Author

@kevinjqliu I'm seeing many of our PRs failing on this check. Ray seems to be very consistently throwing 429s at GitHub actions only (it's working fine on my local machine)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@rambleraptor
rambleraptor force-pushed the markdown-link-check-retry-429 branch from 814c3b6 to c28130d Compare September 14, 2026 21:17
External docs hosts rate-limit the markdown link checker, so note that
external URLs in docs need a markdown-link-check-disable-next-line comment.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01V2AEta8dDFjjxotEvYnb3D
@rambleraptor
rambleraptor force-pushed the markdown-link-check-retry-429 branch from c28130d to 2ec6397 Compare September 14, 2026 21:19
@rambleraptor rambleraptor changed the title CI: Allow 429 success in markdown-link-check CI: Skip link-check on external URIs Sep 14, 2026

@kevinjqliu kevinjqliu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinjqliu

Copy link
Copy Markdown
Contributor

lets see if this works. otherwise we can be more aggressive with configuring the markdown link check

@kevinjqliu
kevinjqliu added this pull request to the merge queue Sep 14, 2026
@rambleraptor

Copy link
Copy Markdown
Collaborator Author

This should get us fixed in the interim. It looks like most of this afternoon's PRs are stuck on the same failed link.

Merged via the queue into apache:main with commit 182169e Sep 14, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants