[lake][follow] Support empty commits for Hudi and Lance to persist tiering progress - #3941
Open
beryllw wants to merge 4 commits into
Open
[lake][follow] Support empty commits for Hudi and Lance to persist tiering progress#3941beryllw wants to merge 4 commits into
beryllw wants to merge 4 commits into
Conversation
Contributor
|
@fhan688 Could you please help review the hudi part? |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #3892 by ensuring lake tiering progress can be persisted even when a tiering round produces no data files (e.g., buckets only advanced past empty WAL batches). It adds empty-commit behavior for Hudi and Lance so Fluss can still record updated bucket log end offsets and avoid repeatedly regenerating the same “empty” split.
Changes:
- Hudi: add an explicit “empty instant” commit path to persist tiering progress even when no writer ran.
- Lance: allow committing an empty set of fragments by switching to a no-op transaction operation that still creates a new dataset version with snapshot properties.
- Add/extend unit tests for empty commits (Hudi + Lance) and document the Hudi configuration caveat.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| website/docs/streaming-lakehouse/datalake-formats/hudi.md | Documents that empty commits must be allowed for tiering progress persistence. |
| fluss-lake/fluss-lake-lance/src/test/java/org/apache/fluss/lake/lance/tiering/LanceTieringTest.java | Adds a test asserting an empty commit creates a new Lance snapshot/version and recovery works. |
| fluss-lake/fluss-lake-lance/src/main/java/org/apache/fluss/lake/lance/utils/LanceDatasetAdapter.java | Adds commitFragments and implements a no-op commit path for empty fragment lists. |
| fluss-lake/fluss-lake-lance/src/main/java/org/apache/fluss/lake/lance/tiering/LanceLakeCommitter.java | Switches to the new commitFragments API. |
| fluss-lake/fluss-lake-hudi/src/test/java/org/apache/fluss/lake/hudi/tiering/HudiTieringTest.java | Adds tests for empty commit success/failure behavior and commit rollback handling. |
| fluss-lake/fluss-lake-hudi/src/main/java/org/apache/fluss/lake/hudi/tiering/HudiLakeCommitter.java | Implements committing an empty Hudi instant and ensures operation type is recorded in commit metadata. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
@fhan688 cc |
Contributor
Author
Contributor
fhan688
reviewed
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3892
Brief change log
Tests
API and Format
Documentation