test: read and set nas.backup.incremental.enabled for the test zone - #13960
Open
jmsperu wants to merge 1 commit into
Open
test: read and set nas.backup.incremental.enabled for the test zone#13960jmsperu wants to merge 1 commit into
jmsperu wants to merge 1 commit into
Conversation
nas.backup.incremental.enabled is a zone-scoped setting, but test_backup_recovery_nas.py read and updated it without a zoneid, so a zone override in the test environment would make the suite read the wrong value. Pass zoneid=cls.zone.id on the read and on both updates, as the other backup smoke tests do for zone-scoped settings. Noted by the Copilot review on the 4.22 backport (apache#13877). Signed-off-by: James Peru <jmsperu@gmail.com>
boring-cyborg
Bot
added
component:integration-test
Python
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13960 +/- ##
============================================
- Coverage 19.73% 19.73% -0.01%
+ Complexity 19956 19954 -2
============================================
Files 6371 6371
Lines 575765 575765
Branches 70478 70478
============================================
- Hits 113642 113632 -10
- Misses 449766 449779 +13
+ Partials 12357 12354 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
nas.backup.incremental.enabledis a zone-scoped setting, buttest_backup_recovery_nas.pyread and updated it without azoneid, so a zone override in the test environment would make the suite read the wrong value (and restore the wrong one intearDownClass). This passeszoneid=cls.zone.idon the read and on both updates, the same waytest_backup_recovery_veeam.pyhandles zone-scoped settings.Noted by the Copilot review on the 4.22 backport #13877; this is the main-side fix so both branches stay in sync.
Types of changes
How Has This Been Tested?
Python syntax check; the change is limited to three Marvin calls in
setUpClass/tearDownClass.