fix: resolve account for SNAPSHOT data objects in DownloadListener (fixes #13900) - #13929
Open
waterWang wants to merge 1 commit into
Open
fix: resolve account for SNAPSHOT data objects in DownloadListener (fixes #13900)#13929waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
…ataObject Fixes apache#13900: copySnapshot between zones fails with "Timeout waiting for response from storage host" when the account lookup returns null for SNAPSHOT data objects. Signed-off-by: waterWang <waterwang@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #13900
Root cause
DownloadListener.getAccountIdForDataObject()only handlesTEMPLATEandVOLUMEdata object types. ForSNAPSHOTdata objects it falls through and returnsnull, socheckAndUpdateResourceLimits()calls_accountMgr.getAccount(null)— the account lookup fails, resource-limit accounting is skipped, the download is never marked successful, andcopySnapshotbetween zones times out after ~90s even though the destination SSVM already finished downloading the snapshot files.Fix
Add a
SNAPSHOTbranch togetAccountIdForDataObject()that looks up the snapshot's account viaSnapshotDao.findById(), mirroring the existingTEMPLATE/VOLUMEbranches. The downloaded snapshot files are already present on the destination store; only the account attribution and resource-count update were missing.Testing
mvn -pl server -am compilepassesSnapshotDaois already used elsewhere in the server module