fix: correct VM snapshot usage attribution (two defects) - #13924
Open
waterWang wants to merge 1 commit into
Open
fix: correct VM snapshot usage attribution (two defects)#13924waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
Fixes apache#13921 Defect 1: createUsageRecord used the current snapshot ID (usageRec) for the usage label, while duration/size/diskOffering came from the previous event. This caused the first snapshot's usage to be credited to the second snapshot. Defect 2: unprocessedUsage key was vmId + volId only, so concurrent snapshots of the same volume overwrote each other. Added vmSnapshotId to the key to distinguish them. Signed-off-by: waterWang <waterwang@proton.me>
waterWang
force-pushed
the
fix-vm-snapshot-usage-attribution
branch
from
August 20, 2026 05:14
3857686 to
6cf39e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13921
Two defects corrected in
VMSnapshotUsageParser:Wrong snapshot ID label in usage record:
createUsageRecord()used the current snapshot's ID (usageRec.getVmSnapshotId()) while duration, size, and disk offering came from the previous event. Changed topreviousEvent.getVmSnapshotId().Concurrent snapshot key collision: The
unprocessedUsagemap keyed entries byvmId + ":" + volIdonly, so concurrent snapshots of the same volume overwrote each other. AddedvmSnapshotIdto the key to distinguish them.Root cause
From the issue body: