Properly exit subshell on error in accumulo-cluster script - #6536
Merged
Merged
Conversation
DomGarguilo
commented
Sep 15, 2026
dlmarion
approved these changes
Sep 16, 2026
dlmarion
left a comment
dlmarion
left a comment
Contributor
There was a problem hiding this comment.
Does this issue exist in 2.1 also?
ddanielr
reviewed
Sep 16, 2026
ddanielr
left a comment
ddanielr
left a comment
Contributor
There was a problem hiding this comment.
I'd repoint this to 2.1 and merge it through to main.
The scripts should match between the 2.1 and main branches.
Member
Author
The bug being fixed here does not exist in 2.1 and was introduced to main in #6091 |
ddanielr
approved these changes
Sep 17, 2026
ddanielr
left a comment
ddanielr
left a comment
Contributor
There was a problem hiding this comment.
Ah yeah you're right. The resource groups didn't get added as a config object until after 2.1.
All changes look good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For this line:
"$accumulo_cmd" zk info-viewer --print-resource-groups >"$RG_FILE" || (echo "Error getting resource groups. Did you init?" && exit 1)If the call fails, the error msg prints and
exit 1runs but inside a subshell. So the subshell exits and the script keeps running. That caused the list of resource groups to be empty which made the following check fail saying that "Resource group default does not exist" which may not be true.This PR fixes things so the subshell exits properly and the script stops where it should. Found 3 total usages of this pattern and fixed them all.