Skip to content

feat: use new credentials manager API for AnkiWeb passwords - #21763

Open
BrayanDSO wants to merge 4 commits into
ankidroid:mainfrom
BrayanDSO:feat/credentials
Open

feat: use new credentials manager API for AnkiWeb passwords#21763
BrayanDSO wants to merge 4 commits into
ankidroid:mainfrom
BrayanDSO:feat/credentials

Conversation

@BrayanDSO

@BrayanDSO BrayanDSO commented Sep 6, 2026

Copy link
Copy Markdown
Member

On top of #21770

Approach

In the commits

How Has This Been Tested?

Galaxy Tab S9, Android 16, Samsung Password manager

Screen_Recording_20260906_140426_AnkiDroid.mp4

Emulator 28, with no credentials manager installed

Screen_recording_20260906_111636.webm

Learning (optional, can help others)

https://developer.android.com/identity/credential-manager

https://developer.android.com/reference/kotlin/androidx/credentials/package-summary

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

so it can be rebuilt on configuration changes
an "event"/sharedFlow approach makes more sense to me, specially under configuration changes where earlier the whole code path would be repeated unnecessarily
@BrayanDSO
BrayanDSO marked this pull request as draft September 6, 2026 14:57
@BrayanDSO
BrayanDSO force-pushed the feat/credentials branch 2 times, most recently from 739d94e to 36a6310 Compare September 6, 2026 16:36
@BrayanDSO
BrayanDSO marked this pull request as ready for review September 6, 2026 17:09
@BrayanDSO BrayanDSO changed the title feat: implement zero-tap-sign-in for AnkiWeb feat: implement one-tap sign-in for AnkiWeb Sep 6, 2026
@BrayanDSO BrayanDSO changed the title feat: implement one-tap sign-in for AnkiWeb feat: use new credentials manager API for AnkiWeb passwords Sep 6, 2026
@david-allison

This comment was marked as resolved.

@BrayanDSO

This comment was marked as resolved.

@BrayanDSO BrayanDSO added the Blocked by dependency Currently blocked by some other dependent / related change label Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Blocked by dependency Currently blocked by some other dependent / related change Needs Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants