feat: use new credentials manager API for AnkiWeb passwords - #21763
Open
BrayanDSO wants to merge 4 commits into
Open
feat: use new credentials manager API for AnkiWeb passwords#21763BrayanDSO wants to merge 4 commits into
BrayanDSO wants to merge 4 commits into
Conversation
so it can be rebuilt on configuration changes
an "event"/sharedFlow approach makes more sense to me, specially under configuration changes where earlier the whole code path would be repeated unnecessarily
BrayanDSO
marked this pull request as draft
September 6, 2026 14:57
BrayanDSO
force-pushed
the
feat/credentials
branch
from
September 6, 2026 16:23
639e19f to
98995da
Compare
BrayanDSO
force-pushed
the
feat/credentials
branch
2 times, most recently
from
September 6, 2026 16:36
739d94e to
36a6310
Compare
BrayanDSO
force-pushed
the
feat/credentials
branch
from
September 6, 2026 17:06
36a6310 to
d31178c
Compare
BrayanDSO
marked this pull request as ready for review
September 6, 2026 17:09
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of #21770
Approach
In the commits
How Has This Been Tested?
Galaxy Tab S9, Android 16, Samsung Password manager
Screen_Recording_20260906_140426_AnkiDroid.mp4
Emulator 28, with no credentials manager installed
Screen_recording_20260906_111636.webm
Learning (optional, can help others)
https://developer.android.com/identity/credential-manager
https://developer.android.com/reference/kotlin/androidx/credentials/package-summary
Checklist
Please, go through these checks before submitting the PR.