Fix aligned indentation crash on malformed CASE input - #894
Open
RamiNoodle733 wants to merge 2 commits into
Open
Fix aligned indentation crash on malformed CASE input#894RamiNoodle733 wants to merge 2 commits into
RamiNoodle733 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #886.
AlignedIndentFilter._process_case()can receive malformed CASE fragments whose representative token is no longer a direct child of the CASE token list. Callinginsert_before()on that token then falls through totoken_index()and raisesValueError: list.index(x): x not in list.This keeps aligned indentation best-effort for malformed SQL by skipping relative insertions for case fragments that cannot be resolved as direct children. It also guards condition whitespace insertion on the same invariant.
A focused regression test covers the reported reproducer and verifies formatting returns a string while preserving the key CASE/END/SELECT tokens.
Checks: the branch diff was verified against current upstream
masterand contains only the aligned-indent guard plus the regression test. Local pytest/ruff were not run because this automation environment does not have a repository checkout/runtime available; CI is relied on for executable verification.