Allow custom lexer instances in FilterStack - #893
Open
RamiNoodle733 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow callers that use
FilterStackdirectly to replace its lexer instance without changing sqlparse's public top-level APIs.FilterStacknow initializesself.lexerfromLexer.get_default_instance()andrun()calls that instance'sget_tokens()method. Existing behavior is unchanged by default, while advanced users can assign a customLexeror compatible lexer object before callingrun().A focused regression test verifies that an injected lexer controls the token stream.
Fixes #806.
Validation
pytest) - not run locally because this automation environment does not have the repository checkout/development dependencies availableruff) - not run locally for the same reasonFilterStackAPI rather than adding a new top-level public functionAI assistance was used to inspect the issue and repository guidance and to implement the focused change. The resulting diff was manually constrained to the requested
FilterStackinjection point plus its regression test.