Add configurable grouping token limit - #892
Open
RamiNoodle733 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a public
sqlparse.set_max_grouping_tokens()helper so callers can adjust the existing grouping token-count DoS guard at runtime for trusted or offline workloads.The default remains unchanged at 10,000 tokens. Passing
Nonedisables the token-count guard, with a docstring warning against doing so for untrusted SQL. Non-positive limits are rejected.Tests cover:
NoneFixes #841
Checks
pytest- not run locally because this execution runtime could not resolvegithub.com, so the repository could not be cloned into the local execution environment.ruff- not run for the same environment limitation.AI-assisted disclosure: This change was prepared with AI assistance. The issue scope, existing DoS guard, public API design, and test cases were reviewed against the repository source and contribution guidance. Local execution was not possible because the runtime could not resolve GitHub; CI should provide execution validation.