rate limiter in logger, opt-in - #62
Open
c-cube wants to merge 5 commits into
Open
Conversation
raphael-proust
left a comment
raphael-proust
left a comment
Contributor
There was a problem hiding this comment.
nothing important, just small potatoes feedback
c-cube
force-pushed
the
sc/rate-limit-in-log
branch
from
August 25, 2026 18:39
2a93b89 to
d6991e0
Compare
rr0gi
requested changes
Aug 25, 2026
| open ExtLib | ||
| open Prelude | ||
|
|
||
| module Rate_limit : sig |
Contributor
There was a problem hiding this comment.
this looks generic enough to be in Cache (or Control?)
|
|
||
| class logger facil = | ||
| let make_s (output_line:Logger.facil -> Time.t -> Logger.Pairs.t -> string -> unit) = | ||
| class logger ?(logger=State.logger) facil = |
Contributor
There was a problem hiding this comment.
it means changes to State will not matter once logger object is created? which goes against the purpose of the state
Contributor
Author
There was a problem hiding this comment.
currently State.logger is already not changeable (only hooks and some internal things are). It hasn't really been changeable in a while, as far as I can tell. The override is only used for testing here, for all intent and purpose we always use Log.State.logger everywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.