docs: state the operator_handle hook-ordering contract - #117
Merged
Conversation
Twin of the node-commerce docs change. The gate that populates ctx.operator_handle runs AFTER pre_validate, so the field is readable from compute_pricing onward and always None inside pre_validate; a pre_validate read passes every keyless-dev test and zero-settles every production request whose flow keys on it (a live store shipped exactly that). The contract now lives on the field's docstring where the mistake gets made. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Twin of node-commerce PR 110. The gate that populates
ctx.operator_handleruns AFTERpre_validate, so the field is readable fromcompute_pricingonward and alwaysNoneinsidepre_validate. Apre_validateread passes every keyless-dev test and zero-settles every production request whose flow keys on it; a live store shipped exactly that (caught by its first real settle, fixed store-side). The contract now lives on the field's docstring, where the mistake gets made, plus the CLAUDE.md operator-handle section. Worked with Varun.Type of change
Public API
None; docstring/doc text only.
Test plan
Docs-only;
uv run ruff checkpasses locally. No behavior to test.Checklist