Skip to content

some InstanceContentText related structs and functions - #1902

Merged
Haselnussbomber merged 5 commits into
aers:mainfrom
AtmoOmen:InstanceContentText
Sep 7, 2026
Merged

some InstanceContentText related structs and functions#1902
Haselnussbomber merged 5 commits into
aers:mainfrom
AtmoOmen:InstanceContentText

Conversation

@AtmoOmen

@AtmoOmen AtmoOmen commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

i will update all addresses after 7.55 update

@wolfcomp wolfcomp added the outdated New patches have been released since this pr and it could be wrong label Jul 28, 2026
@AtmoOmen
AtmoOmen force-pushed the InstanceContentText branch from 636a32b to 99fe7af Compare July 28, 2026 10:42
@Haselnussbomber Haselnussbomber removed the outdated New patches have been released since this pr and it could be wrong label Jul 28, 2026
wolfcomp
wolfcomp requested changes Aug 6, 2026
View reviewed changes

@wolfcomp wolfcomp left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know the reason for these

Comment thread FFXIVClientStructs/FFXIV/Client/Game/InstanceContent/ContentDirector.cs Outdated
Comment thread FFXIVClientStructs/FFXIV/Client/Game/InstanceContent/ContentDirector.cs Outdated
Comment thread FFXIVClientStructs/FFXIV/Client/Game/InstanceContent/ContentDirector.cs Outdated
Comment thread FFXIVClientStructs/FFXIV/Client/Game/InstanceContent/ContentDirector.cs Outdated
Comment thread FFXIVClientStructs/FFXIV/Client/System/Scheduler/Clip/InstanceContentTextClip.cs Outdated
Comment thread FFXIVClientStructs/FFXIV/Client/System/Scheduler/Clip/InstanceContentTextClip.cs Outdated
@AtmoOmen

AtmoOmen commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

all done

@AtmoOmen
AtmoOmen force-pushed the InstanceContentText branch from ecf0660 to b12475b Compare August 8, 2026 10:36
@AtmoOmen
AtmoOmen force-pushed the InstanceContentText branch from b12475b to 5f2bcd9 Compare August 14, 2026 17:23
@AtmoOmen
AtmoOmen requested a review from wolfcomp August 14, 2026 17:26
@Haselnussbomber

Haselnussbomber commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Looks good to me except for the Data field that's part of the parent struct.
Not sure what to do with it. Maybe the others have an idea.

For reference, I also found this here, which should be InstanceContentTextClipData:
https://github.com/0ceal0t/Dalamud-VFXEditor/blob/main/VFXEditor/Formats/TmbFormat/Entries/C216.cs
Parent classes seems to have Id and Time fields, and the C216 itself has an Enabled field that's not in here. Just in case you're interested in that. 🤷‍♂️ I don't even know how to test it.

@AtmoOmen

AtmoOmen commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

Looks good to me except for the Data field that's part of the parent struct. Not sure what to do with it. Maybe the others have an idea.

For reference, I also found this here, which should be InstanceContentTextClipData: https://github.com/0ceal0t/Dalamud-VFXEditor/blob/main/VFXEditor/Formats/TmbFormat/Entries/C216.cs Parent classes seems to have Id and Time fields, and the C216 itself has an Enabled field that's not in here. Just in case you're interested in that. 🤷‍♂️ I don't even know how to test it.

Thanks for the C216 reference. I've moved the raw Data pointer into BaseClip and added a TypedData property to InstanceContentTextClip.

@Haselnussbomber
Haselnussbomber merged commit 0a95099 into aers:main Sep 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfcomp wolfcomp Awaiting requested review from wolfcomp

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AtmoOmen @Haselnussbomber @wolfcomp