fix: disable gasless voting for smart contract wallets - #3093
Open
JoaquinBattilana wants to merge 1 commit into
Open
fix: disable gasless voting for smart contract wallets#3093JoaquinBattilana wants to merge 1 commit into
JoaquinBattilana wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Mjolnir Security Review
13 PRs reviewed |
sammdec
approved these changes
Aug 26, 2026
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
mgrabina
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Smart contract wallets (e.g. Safe) can't use the gas-sponsored voting path: the relay submits
submitVoteBySignature, which verifies the vote withecrecover, so the signer must be an EOA. A Safe's EIP-1271 signature can't be represented asv, r, sand would never recover to the Safe address.This gates the relay path on
useIsContractAddress(user, votingChainId)— the wallet must already be on the voting chain to sign the typed data, so that's where a contract wallet will have code. Contract wallets go straight to the existing self-paidsubmitVoteflow (no signature prompt, no relay error). The gate fails closed while the lookup resolves.This mirrors the permit → approve fallback used elsewhere in the app and the behaviour of the Aave governance interface (
gelatoNotAvailableGnosis).Test plan
NEXT_PUBLIC_ENABLE_GASLESS_VOTING=true: vote goes through the relay as beforesubmitVotedirectlyNEXT_PUBLIC_ENABLE_GASLESS_VOTING=false: unchanged, self-paid for everyone