v492.0 rc8 dev - #372
Open
GernotMaier wants to merge 3 commits into
Open
v492.0 rc8 dev#372GernotMaier wants to merge 3 commits into
GernotMaier wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The logic change is small, targeted, and correctly addresses the midnight-crossing termination condition, with only a minor changelog wording nit noted.
Pull request overview
Fixes an edge case in reduced pointing tree generation so run-duration iteration works correctly when a run crosses UTC midnight (where the stop “time-of-day” can be smaller than the current time-of-day).
Changes:
- Adjust the loop termination condition in
generateReducedPointingTreeData()to handle crossing midnight correctly. - Add a changelog entry documenting the bug fix.
File summaries
| File | Description |
|---|---|
| src/VArrayAnalyzer.cpp | Updates reduced pointing tree fill loop condition to handle UTC midnight rollover correctly. |
| docs/changes/371.bugfix.md | Documents the reduced pointing tree midnight-crossing bug fix. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
GernotMaier
marked this pull request as ready for review
September 5, 2026 13:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.