Conversation
urfeex
commented
Sep 18, 2026
- RobotType definitions
- RobotSeries definition
- Startupscript arguments (preparation for 10.15.0)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #577 +/- ##
==========================================
+ Coverage 15.98% 17.93% +1.94%
==========================================
Files 121 121
Lines 7257 7289 +32
Branches 3227 3232 +5
==========================================
+ Hits 1160 1307 +147
+ Misses 5998 5865 -133
- Partials 99 117 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
- RobotType definitions - RobotSeries definition - Startupscript arguments (preparation for 10.15.0)
aedf191 to
1349be0
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The implementation consistently adds G-series support with appropriate version validation and focused test coverage.
Pull request overview
Adds G-series robot support across type definitions, series detection, URSim startup validation, and parsing.
Changes:
- Defines three G-series robot types and the
G_SERIESclassification. - Supports G-series URSim models starting with version 10.15.0.
- Extends parser, datatype, helper, and startup-script tests.
File summaries
| File | Description |
|---|---|
include/ur_client_library/ur/datatypes.h |
Adds G-series enums and string conversions. |
include/ur_client_library/helpers.h |
Documents supported G-series model strings. |
src/helpers.cpp |
Maps G-series models and versions. |
scripts/start_ursim.sh |
Adds G-series startup and validation support. |
tests/test_datatypes.cpp |
Tests new enum conversions. |
tests/test_helpers.cpp |
Tests model and series mapping. |
tests/test_primary_parser.cpp |
Tests parsing G-series type IDs. |
tests/test_start_ursim.bats |
Tests G-series URSim handling. |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
PR SummaryLow Risk Overview The library now defines
Tests cover datatype strings, series/version logic, primary hardware info parsing for the new type IDs, and bats cases for series inference, version gates, and docker env vars. Reviewed by Cursor Bugbot for commit 1349be0. Bugbot is set up for automated code reviews on this repo. Configure here. |