fix(ui5-popover): prevent horizontal position drift on reposition - #13987
Open
LidiyaGeorgieva wants to merge 4 commits into
Open
fix(ui5-popover): prevent horizontal position drift on reposition#13987LidiyaGeorgieva wants to merge 4 commits into
LidiyaGeorgieva wants to merge 4 commits into
Conversation
The popover is repositioned every 300ms by PopoverRegistry. The RTL correction was added to the persisted `this._left` after the 1.5px dead-band check, so whenever the dead-band kept `this._left` unchanged the correction was re-applied every tick and accumulated, causing the popover to slowly drift and misalign with its opener. This was most visible at fractional zoom levels, where getBoundingClientRect().left is snapped to device pixels and yields a persistent sub-pixel correction. Apply the correction to the raw left before the dead-band check so it is baked into `this._left` once and stays stable across repositions. fixes: #13863
LidiyaGeorgieva
had a problem deploying
to
netlify-preview
August 26, 2026 13:05 — with 
GitHub Actions
Failure
GitHub Actions
Failure
|
🚀 Deployed on https://pr-13987--ui5-webcomponents-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The popover is repositioned every 300ms by PopoverRegistry. The RTL correction was added to the persisted
this._leftafter the 1.5px dead-band check, so whenever the dead-band keptthis._leftunchanged the correction was re-applied every tick and accumulated, causing the popover to slowly drift and misalign with its opener. This was most visible at fractional zoom levels, where getBoundingClientRect().left is snapped to device pixels and yields a persistent sub-pixel correction.Apply the correction to the raw left before the dead-band check so it is baked into
this._leftonce and stays stable across repositions.fixes: #13863