feat: Disable generation of library manifest

[d3xter666]

JIRA: CPOUI5FOUNDATION-1156

This change disables the generateLibraryManifest task and enforces a manifest presence for non-framework libraries

[d3xter666]

Hi @KlattG

Would you take a look at the modified docs:

• internal/documentation/docs/pages/Builder.md (Rendered version)
• internal/documentation/docs/updates/migrate-v5.md (Rendered version)

Cheers

[KlattG]

One minor suggestion, otherwise fine

[d3xter666]

Not quite sure whether we need to keep the BREAKING CHANGE in the description. It's breaking as of specVersion: 5 and is mentioned in the migration guide. But as we discussed, existing projects with specVersions < 5 are not affected

[matz3]

Not quite sure whether we need to keep the BREAKING CHANGE in the description. It's breaking as of specVersion: 5 and is mentioned in the migration guide. But as we discussed, existing projects with specVersions < 5 are not affected

Yes, BREAKING CHANGE should be removed, because upgrading the specVersion is not bound to upgrading the npm package. We should only describe breaking changes in commits (conventional commits) if something changes when upgrading the npm package. If we would merge this PR when we already have a stable v5 released, we would also not bump the version to v6. Therefore, not a breaking change.

[flovogt]

UA review done by @KlattG and @flovogt

[RandomByte]

Implementation is acceptable. I didn't review the doc changes

[d3xter666]

Thank you for your review, @RandomByte!

I just wanted to clarify certain things as I still have some concerns regarding this:

As Matthias already mentioned, if a build manifest exists, the project has already been built by UI5 CLI and is therefore guaranteed to contain a manifest.json. Of course we can check again, but then why don't we do that for e.g. the Component type?

Here's my interpretation and why I have build it that way:
The buildManifest stores the computed namespace, not a guarantee that the source manifest.json still exists. If someone deletes manifest.json after a successful build that wrote a build-manifest.json, the buildManifest would be stale. That's why, IMO we need this explicit check.

I also saw that the Application and Component try out the manifest.appdescr_variant! In the BLI I didn't see something about it. Is it applicable also here?

[RandomByte]

Implementation LGTM. Did not review the docs as agreed.

Request edit was obsolete