Skip to content

Prohibit bad sieve / trial divison combinations #39

Description

@TilmanNeumann

Currently it is possible to create subclasses of PSIQSThread that combine sieve and trial divsion classes that would work together very slowly.

For example, using Sieve03g with TDiv_QS_2LP in class PSIQSThread would be very bad because the trial division class expects that small factors have already been resolved; but the sieve class does not do that. The combination still works but very slowly.

This should be prohibited by software design (or at least by runtime checks)

Sidenote: The correct thing would be to combine

  • Sieve03g with TDiv_QS_2LP_Full, or
  • Sieve03h with TDiv_QS_2LP.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions