fix: make bad character shift effective in boyer_moore_search - #15043
Open
deepshekhardas wants to merge 1 commit into
Open
fix: make bad character shift effective in boyer_moore_search#15043deepshekhardas wants to merge 1 commit into
deepshekhardas wants to merge 1 commit into
Conversation
The for-loop variable reassignment had no effect; use a while loop so the bad-character rule actually skips positions (O(n/m) not O(nm)). Fixes TheAlgorithms#14844
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
What does this implement/fix?
The bad-character shift was dead code: reassigning the or-loop variable i has no effect, so the algorithm degraded to brute-force O(nm). Rewrite as a while loop so the shift actually skips positions.
Additional comments?
None.
Fixes #14844