psm: implement the missing checkShort - #11296
Open
gadfort wants to merge 4 commits into
Open
Conversation
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements a comprehensive short-checking mechanism in the Power Source Manager (psm) tool by introducing the IRShort class hierarchy and integrating it into IRSolver using Boost geometry R-trees. The feedback highlights several critical safety and code quality improvements, such as adding null checks for nets, instances, and marker categories to prevent potential crashes, explicitly including <fmt/format.h> and to ensure self-contained headers, and using prefix increments on Boost query iterators to optimize performance.
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It was clear that providing short information along with open in #10955 was needed.
This implements the missing stub. This should be checked carefully as any flows that call check_power_grid will be impacted if there are false positives.
One possibility would be to make this opt-in?
Type of Change
Impact
Will now flag if the power grid is shorting to something.
Verification
./etc/Build.sh).