Remove AESCrypt password in logs, and generate device's own SSL certificate for FTP server - #4719
Open
TranceLove wants to merge 6 commits into
Conversation
Also remove log statement in setPassword()
…tock prefab ones Prevent abusing FTP server SSL certificate
…tock prefab ones Prevent abusing FTP server SSL certificate
…tock prefab ones Prevent abusing FTP server SSL certificate Also provides dialog to display generated certificate information and copy to clipboard
TranceLove
force-pushed
the
bugfix/aescrypt-logging-ftps-keystore-password
branch
from
September 9, 2026 16:19
082c089 to
5982b99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note: FTP clients will need to accept updated SSL certificates upon connection.
Android's own KeyGenParameterSpec was used at the first attempt to generate the private key in an even more secure way, but turned out it's not compatible with Apache ftpserver, hence resorted to the original simple and compatible way instead.
Automatic tests
Manual tests
Done
Device: Fairphone 5
OS: Lineage OS 23 (16)
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheckGenerative code
Github Copilot with GPT 5.4 mini was stepped in on deciding writing Espresso tests over Robolectric ones, as AndroidKeystore is used.