Add per-option controls and structured cluster labels to the cloud provider dropdown - #2694
Draft
morgan-wowk wants to merge 1 commit into
Draft
Add per-option controls and structured cluster labels to the cloud provider dropdown#2694morgan-wowk wants to merge 1 commit into
morgan-wowk wants to merge 1 commit into
Conversation
🎩 PreviewA preview build has been created at: |
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
morgan-wowk
force-pushed
the
add-eo9-cloud-provider-and-option-controls
branch
from
September 1, 2026 22:10
76d5e74 to
996d2ea
Compare
morgan-wowk
force-pushed
the
add-eo9-cloud-provider-and-option-controls
branch
2 times, most recently
from
September 4, 2026 21:18
86818aa to
63856db
Compare
morgan-wowk
force-pushed
the
add-eo9-cloud-provider-and-option-controls
branch
from
September 4, 2026 22:43
63856db to
2f4d0cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Extends the schema-driven Cloud Provider dropdown (TaskNode annotations editor) with per-option controls, richer structured option labels, and legacy-key resolution — no new dropdown, reusing the existing
launcher_annotation_schemas-derived pipeline.Per-option controls
x-active !== falseand itsfeature-flag-key(if any) is enabled.titlegives a friendly display name while the value written to the backend stays the launcher key.x-deprecated(+ optionalx-deprecated-message) renders a smallTriangleAlerticon with a tooltip beside the option, reusing the existing inline icon+tooltip primitive.Structured provider / project / cluster labels
New
x-provider/x-project/x-clusterschema fields flow ontoAnnotationOption. Whenprovideris present the dropdown item renders two lines — a primary provider line and a mutedcluster · projectsecondary line — so an option can identify platform, project, and cluster at a glance while staying accessible and following the existing UI primitives.To keep the collapsed control compact, the trigger no longer uses
SelectValue; it renders a single-line summary (provider · cluster) from the selected option. Radix still tracks the value via eachSelectItem'svalue, and the rich content remains insideItemTextfor typeahead/a11y.Legacy-key resolution
resolveLauncherKeymaps a persistedcloud_providervalue onto its current launcher key via anx-legacy-keysalias array on the canonical entry.getProviderSchemaand the compute-resources editor resolve through it, so an overlay can rename a launcher key (e.g.google→ a cluster id) without stranding existing pipelines that persisted the old value — they keep resolving to the renamed launcher instead of rendering an empty compute panel. When no alias applies the value passes through unchanged, so this is a no-op for current keys.System / UX impact
AnnotationsSection) and v2 (ConfigurationSection) editors render through the sameAnnotationsInput, so this covers both.x-provider(e.g. Davies) keep the existing single-line rendering.Tests
AnnotationsEditor/utils.test.tscovers the parse layer:x-activegating (both mechanisms), label ≠ value, deprecated flag + message (launcher and enum paths), provider/project/cluster population, andresolveLauncherKey/getProviderSchemalegacy-key resolution.pnpm typecheck,pnpm lint,pnpm test,pnpm format:checkall pass.