feat(frontend):reject projects - #256
Merged
Merged
Conversation
The organiser could approve a proposal or revoke an approval, but not turn one down. #252 added ProjectService.Reject with an optional reason; this is the frontend half. Rejecting lives on a project's own page under Manage Projects, not on the queue: it is the one decision that takes prose, and a reason is written after reading the proposal. Approve, Revoke approval and Reconsider stay one click each on the queue, so every action still has exactly one place it can be taken from. The reason reaches its author as a review note on their project. That needed two fixes on the participant side: a rejected proposal used to vanish from its author's view entirely, and — once REJECTED existed — would have been readable by every member of the hackathon.
Reject writes a "Project rejected" comment alongside the reason, so the proposer saw the same name and date on two lines. The marker now becomes the section's attribution line, with reasons beneath it.
rejectReason on projectSpec left every other literal incomplete, which exhaustruct rejects. go.sum picked up entries from a `go build` run without GOWORK=off; a tidy removes them again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As an owner, I turn down a proposal and write why. As the participant who proposed it, I open my project and read one thing: who rejected it, when, and what they said.
Before, the participant read it twice — the backend writes a "Project rejected" comment next to every reason, and both rendered as notes with the same byline and timestamp, the first saying nothing the Rejected badge hadn't.
Left out: per-reason bylines. If two owners each wrote a reason across separate rejections, only the latest is named — the alternative reintroduces the duplication this fixes.