Split line: keep all ASSA tags and strip dialog dash on tagged lines - #14801
Merged
Conversation
Fixes #14800. - PropagateAssaTags now walks each {\...} override block and tracks the active bold/italic/underline/font/colour state, so a toggle that is not last in a merged block ("{\i1\c&H00ff00&}") is still re-opened on the second half; {\c} and {\r} reset the tracked state. - The two-line dialog split now uses DialogSplitMerge.RemoveStartDash so a line like "{\i1}- Hi!{\i0}" loses its dash too; GetStartTags skips several leading ASSA blocks. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14800.
Italic lost on split. The ASSA reader merges adjacent override blocks, so
{\i1}{\c&H00ff00&}arrives as{\i1\c&H00ff00&}. The split propagation matched on the literal\i1}, which no longer occurs, so italic was dropped from the second half. Propagation now parses each{\...}block into tags and tracks the active bold/italic/underline/font/colour state, honouring{\c}and{\r}resets.Dash kept on a tagged dialog line. The two-line dialog split trimmed dashes from the raw line, so
{\i1}- Hi!{\i0}kept its dash. It now usesDialogSplitMerge.RemoveStartDash, which skips leading tags, andGetStartTagshandles more than one leading ASSA block.Tests added in
SplitManagerTestsfor the merged block, the colour reset, and dialog lines with ASSA/HTML tags.🤖 Generated with Claude Code