Subtitle grid: more "Selected lines" context menu items - #14798
Merged
Conversation
Add "Adjust durations...", "Apply duration limits..." and "Change formatting..." to the grid's Selected lines submenu, each working on the selected rows only. Adjust durations and Apply duration limits still walk the whole grid so a selected line is capped against its real neighbour, not the next line that happened to be selected. The submenu's "Text to speech" item ran the whole-file command; it now opens the TTS window with just the selected lines (and their original lines when an original is shown). A TTS merge can then only swallow rows inside the selection, since lines adjacent in the selection need not be adjacent in the grid. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
AdjustDurationViewModelTestsandApplyDurationLimitsViewModelTestspass, including two new tests for the selected-rows filters.ShorteningStillWorksWhenTheUnusedMinimumIsHigherThanTheMaximumfails onmainas well (pre-existing, unrelated).🤖 Generated with Claude Code