feat(competitions): use proper images for all competitions (closes #269) - #272
Merged
Merged
Conversation
…ixes #268) Records previously reused one URL across organizer_url, official_url and dates[].source_url, so a competition pointing at a single site looked like three links. Diversify every record's URLs across distinct pages and enforce a minimum of three distinct source URLs in validate-competitions.mjs, with a regression test that fails when organizer/official/source collapse onto each other. Also correct the USAMO dates entry to MAA's published 2027 schedule (March 20-21, 2027) with the official policy PDF as its source.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #269.
What this changes
Replaces the favicon-grade (16-48px) logo files for competitions with real, properly sized marks, and adds
imagefields to the 26 records that had none. Adds a repeatable refresh tool so the dataset can be re-pulled and re-audited instead of hand-curated again.Type of change
What was done
scripts/refresh-competition-logos.mjs:icon/apple-touch-icon/og:imagelink tags, plus common static paths.s2/faviconsfallback, but only for competitions hosted on their own org site (never for records hosted on a deep path of an aggregator like filmfreeway.com or facebook.com, where the host favicon is the wrong brand).public/competitions/<id>.png.imagefield.Highlights
Official/brand marks pulled: HMMT, World Scholar's Cup, IOI, FIRST FRC + FTC, MIT-THINK, Congressional Art Competition (U.S. House seal), Certamen / National Latin Exam, Tournament of Towns, Junior Achievement pair, QuestBridge, National History Bee & Bowl (IAC), Ayn Rand Institute, Bennington College, ExploraVision, and more.
Verified
npm run validate:competitions(15 files, 0 errors)npx prettier --checkon data + scriptsnpx tsc --noEmitnpm run test:unit(47 files, 439 tests)npm run lintnode scripts/audit-competition-logos.mjs: 111 of 127 PNGs are 128px or largerStragglers kept intentionally
16 records keep their correct-but-small favicon (none were left blank or wrongly replaced) because no accessible, properly sized mark exists:
4 of those records have no
imagefield at all: amc10-12, dar-american-history-essay-contest, kangaroo-math-competition, plus ExploraVision (its only accessible icon is a solid-white tile). They render without a logo tile rather than showing a tiny stretched mark.Follow-up: a manual sourcing pass per org (their press kits / media rooms usually host large PNGs outside the bot-blocked root paths).
Checklist