Avoid printing sensitive store auth URLs - #8427
Open
dengjeffrey wants to merge 1 commit into
Open
Conversation
dengjeffrey
force-pushed
the
redact-store-auth-manual-url
branch
from
August 28, 2026 20:57
b7184a6 to
d555d4c
Compare
dengjeffrey
marked this pull request as ready for review
August 28, 2026 21:41
dengjeffrey
force-pushed
the
redact-store-auth-manual-url
branch
from
August 28, 2026 21:43
d555d4c to
1ea45d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent Shopify CLI from printing manual store authorization URLs that the caller has marked as sensitive.
Context
The Stripe-backed
store:stripe-authflow passes the signup JWT through the OAuth authorization URL as thesignupquery parameter.The normal path opens that URL in the browser and does not print it. If the browser cannot be opened automatically, the fallback path previously printed the full manual URL to the terminal. That could expose the signup JWT in shell history, logs, screenshots, or CI output.
Implementation
sensitiveoption to the manual auth URL presenter API.signup.sensitiveis true and shows safer guidance instead.This keeps the sensitivity decision at the point where we know why the URL is sensitive, rather than having the presenter parse and infer sensitive query parameters after the fact.
Testing