Skip to content

[Refactor] Use declarative array methods in filterCustomHeaders #8421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gonzaloriestra wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −7
Draft

[Refactor] Use declarative array methods in filterCustomHeaders #8421

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04b9a35
[Refactor] Use declarative array methods in filterCustomHeaders
gonzaloriestra Aug 28, 2026
b1313f8
[Refactor] Use declarative array methods in filterCustomHeaders
gonzaloriestra Aug 28, 2026
145d0f5
[Refactor] Use declarative array methods in filterCustomHeaders
gonzaloriestra Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions packages/cli-kit/src/public/node/graphiql/utilities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,8 @@ const BLOCKED_HEADERS = new Set([
* @returns The subset of headers that are safe to forward to the Admin API.
*/
export function filterCustomHeaders(headers: {[key: string]: string | string[] | undefined}): {[key: string]: string} {
const customHeaders: {[key: string]: string} = {}
for (const [key, value] of Object.entries(headers)) {
if (!BLOCKED_HEADERS.has(key.toLowerCase()) && typeof value === 'string') {
customHeaders[key] = value
}
}
return customHeaders
const validEntries = Object.entries(headers).filter(
(entry): entry is [string, string] => !BLOCKED_HEADERS.has(entry[0].toLowerCase()) && typeof entry[1] === 'string',
)
return Object.fromEntries(validEntries)
}
Loading