New loading indicator - #8136
Open
gonzaloriestra wants to merge 1 commit into
Open
Conversation
gonzaloriestra
force-pushed
the
new-spinner
branch
from
July 21, 2026 09:40
66ed190 to
b5093f8
Compare
gonzaloriestra
force-pushed
the
new-spinner
branch
from
July 21, 2026 09:45
b5093f8 to
ec6b98a
Compare
This was referenced Jul 21, 2026
gonzaloriestra
force-pushed
the
new-spinner
branch
from
July 24, 2026 10:07
ec6b98a to
510a617
Compare
gonzaloriestra
force-pushed
the
new-spinner
branch
from
July 27, 2026 08:32
510a617 to
09484b1
Compare
gonzaloriestra
force-pushed
the
new-spinner
branch
from
July 27, 2026 09:13
09484b1 to
2214bbf
Compare
gonzaloriestra
marked this pull request as ready for review
July 27, 2026 09:42
gonzaloriestra
force-pushed
the
new-spinner
branch
from
July 27, 2026 10:19
2214bbf to
0b4d336
Compare
gonzaloriestra
force-pushed
the
new-spinner
branch
from
August 7, 2026 08:11
0b4d336 to
79ba982
Compare
gonzaloriestra
force-pushed
the
new-spinner
branch
from
August 7, 2026 09:21
79ba982 to
3aafb74
Compare
gonzaloriestra
force-pushed
the
new-spinner
branch
2 times, most recently
from
August 7, 2026 11:08
3d7da2b to
fee6455
Compare
gonzaloriestra
force-pushed
the
new-spinner
branch
from
August 7, 2026 12:52
fee6455 to
c5ae4c3
Compare
gonzaloriestra
force-pushed
the
new-spinner
branch
from
August 10, 2026 07:50
b868c34 to
450e28c
Compare
gonzaloriestra
force-pushed
the
new-spinner
branch
2 times, most recently
from
August 12, 2026 08:03
2f563f4 to
b4f50e6
Compare
gonzaloriestra
force-pushed
the
new-spinner
branch
from
August 12, 2026 08:15
b4f50e6 to
8db153f
Compare
gonzaloriestra
force-pushed
the
new-spinner
branch
from
August 12, 2026 08:39
8db153f to
221b5a1
Compare
gonzaloriestra
force-pushed
the
new-spinner
branch
2 times, most recently
from
August 13, 2026 08:43
7dec6dd to
d9cbb2c
Compare
gonzaloriestra
force-pushed
the
new-spinner
branch
from
August 13, 2026 10:03
d9cbb2c to
0fac677
Compare
gonzaloriestra
changed the base branch from
mouse-support
to
graphite-base/8136
August 13, 2026 14:31
gonzaloriestra
force-pushed
the
new-spinner
branch
from
August 13, 2026 14:31
0fac677 to
27a3244
Compare
gonzaloriestra
changed the base branch from
graphite-base/8136
to
background-analytics
August 13, 2026 14:31
gonzaloriestra
force-pushed
the
new-spinner
branch
from
August 14, 2026 11:09
27a3244 to
9310761
Compare
gonzaloriestra
force-pushed
the
new-spinner
branch
from
August 14, 2026 13:01
9310761 to
3b4db70
Compare
gonzaloriestra
force-pushed
the
new-spinner
branch
from
August 28, 2026 11:43
3b4db70 to
f5c9815
Compare
gonzaloriestra
force-pushed
the
new-spinner
branch
from
August 28, 2026 13:38
f5c9815 to
6aca6e8
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationspackages/cli-kit/dist/private/node/ui/components/LoadingIndicator.d.tsimport React from 'react';
interface LoadingIndicatorProps {
title: string;
noColor?: boolean;
}
declare const LoadingIndicator: ({ title, noColor }: LoadingIndicatorProps) => React.JSX.Element;
export { LoadingIndicator };
Existing type declarationspackages/cli-kit/dist/public/node/ui.d.ts@@ -322,9 +322,9 @@ export interface RenderSingleTaskOptions<T> {
renderOptions?: RenderOptions;
}
/**
- * Awaits a single task and displays a loading bar while it's in progress. The task's result is returned.
+ * Awaits a single task and displays a loading indicator while it's in progress. The task's result is returned.
* @param options - Configuration object
- * @param options.title - The initial title to display with the loading bar
+ * @param options.title - The initial title to display with the loading indicator
* @param options.task - The async task to execute. Receives an updateStatus callback to change the displayed title.
* @param options.renderOptions - Optional render configuration
* @returns The result of the task
packages/cli-kit/dist/public/node/ui/components.d.ts@@ -1,4 +1,5 @@
export { ConcurrentOutput, ConcurrentOutputContext, useConcurrentOutputContext, } from '../../../private/node/ui/components/ConcurrentOutput.js';
export { Alert } from '../../../private/node/ui/components/Alert.js';
export { Link } from '../../../private/node/ui/components/Link.js';
+export { LoadingIndicator } from '../../../private/node/ui/components/LoadingIndicator.js';
export { TabularData } from '../../../private/node/ui/components/TabularData.js';
\ No newline at end of file
|
Contributor
|
/snapit |
Contributor
|
🫰✨ Thanks @dmerand! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260828140545Caution After installing, validate the version by running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
HackDays project: https://vault.shopify.io/hackdays/154/projects/24279-Shopify-CLI-UX-improvements
The CLI uses multiple spinner implementations with inconsistent visuals and behavior.
WHAT is this pull request doing?
Replaces task and app dev spinners with a shared Shopify-branded loading indicator.
demo.mp4
How to test your changes?
pnpm i -g @shopify/cli@0.0.0-snapshot-20260811121607shopify app initshopify app devChecklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add