Skip to content

Adopt CalVer, starting at 2026.9.0 - #94

Merged
vpetersson merged 2 commits into
Screenly:masterfrom
vpetersson-bot:release/calver-2026.9.0
Sep 22, 2026
Merged

vpetersson merged 2 commits into
Screenly:masterfrom
vpetersson-bot:release/calver-2026.9.0

Conversation

@vpetersson-bot

Copy link
Copy Markdown
Contributor

What

Moves the integration to CalVer YYYY.M.MICRO, starting at 2026.9.0:
package.json, package-lock.json, and the release/version sections of the
developer documentation.

Why the two version fields had drifted

package.json and package-lock.json said 0.6.0 while the newest tag was
v0.6.1. Those two are not interchangeable:

  • zapier push reads package.json — that is the version Zapier receives.
  • The tag only triggers zapier-release.yml.

At v0.6.1, package.json still said 0.6.0 (git show v0.6.1:package.json),
so that release deployed 0.6.0 under a tag calling itself 0.6.1. Nothing
compares the two, so nothing reported it. The docs now say which source is
authoritative and in what order to change them.

What is not in this PR

A guard in zapier-release.yml that fails the deploy when the tag and
package.json disagree. I could not push it — the token I have lacks the
workflow scope. It is four lines, after the Set up Node.js step:

      - name: Verify tag matches package.json version
        run: |
          PKG=$(node -p "require('./package.json').version")
          if [ "${GITHUB_REF_NAME#v}" != "$PKG" ]; then
            echo "Tag $GITHUB_REF_NAME does not match package.json version $PKG"
            exit 1
          fi

Worth adding by someone who can — it is the only thing that would have caught
the v0.6.1 case at the time rather than a month later.

Releasing after this merges

git tag -a v2026.9.0 -m "New release"
git push origin v2026.9.0

Everything on master since v0.6.1 is security and dependency work
(puppeteer-core for CVE-2026-56876 and the extract-zip symlink traversal,
postcss, ip-address, smol-toml, markdownlint-cli) plus the Node floor raised to
match puppeteer-core@25's engine requirement. That last one is the only
behavioural change and it is a build-environment constraint, not a runtime one.

🤖 Generated with Claude Code

Moves the integration to CalVer YYYY.M.MICRO and closes the gap between
the two version sources: package.json and package-lock.json were still on
0.6.0 while the newest tag was v0.6.1.

They are not interchangeable. `zapier push` reads package.json, and the
tag only starts the workflow, so the tag is the label and package.json is
what Zapier actually receives. When v0.6.1 was pushed, package.json said
0.6.0, so that release deployed 0.6.0 under a tag calling itself 0.6.1.
Nothing compared the two, so nothing said so.

The developer documentation now names which source is authoritative and
the order to change them in.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings September 22, 2026 09:22

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Reconcile the remaining semantic-versioning guidance in CONTRIBUTING.md with the CalVer workflow.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 High severity

Open (1)
What changed in this PR

Adopts CalVer 2026.9.0 and updates release/versioning guidance.

Changes:

  • Updates package.json and package-lock.json.
  • Documents CalVer tagging and package version authority.
File Summary
package.json Sets version to 2026.9.0.
package-lock.json Synchronizes version metadata.
docs/​developer-documentation.md Updates CalVer release guidance; conflicting semver guidance remains in CONTRIBUTING.md.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/developer-documentation.md
CONTRIBUTING.md still told maintainers releases follow semantic
versioning, which is now the opposite of the documented workflow — the
kind of leftover that produces a v0.7.0 next month. It points at the
Version Management section instead.

The Zapier deployment bullet is reworded so Prettier does not break
`zapier push` across a line boundary and unindent the continuation.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings September 22, 2026 09:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The only finding is a non-blocking documentation nit.

Review effort: Lite
Findings: None

Resolved since last review (1)
Previously missed (1)

In code that hasn't changed since last review

Low severity Update stale release guidance from main to master

CONTRIBUTING.md:82

The release process still says approved PRs are merged to main at line 80, while the new release instructions and the repository's branch-filtered workflows use master (.github/workflows/test.yml:5, .github/workflows/lint.yml:5). Please update the stale branch reference so contributors do not follow conflicting release guidance.

@vpetersson
vpetersson merged commit adc2abc into Screenly:master Sep 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants