Light and overlay fixes [develop] [4/4] - #922
Open
PetrilloAtWork wants to merge 167 commits into
Open
Conversation
…plate It used to end when the template SPR goes under 1e-4 ADC#. Now it needs to stay within +/- 1w-4 ADC# for 20 nanoseconds. This should make it possible to include undershootings. All these parameters are currently hard-coded.
…icles that might cross cathode
Good catches on names and strings. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: mvicenzi <64699641+mvicenzi@users.noreply.github.com> Co-authored-by: Gianluca Petrillo <petrillo.at.work@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>
Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>
PetrilloAtWork
added
breaking
PetrilloAtWork
changed the title
develop] [1/4]develop] [4/4]
This was referenced Aug 21, 2026
PetrilloAtWork
marked this pull request as ready for review
August 21, 2026 20:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the mirror set of pull requests as #917 and #892 (and all dependent ones).
The approval of the content of this PR is in principle the same as for those, but because this branch was obtained by cherry-picking, some additional scrutiny may be justified.
Additional PR are required before/together with this one:
develop] [1/4] sbnalg#10develop] [2/4] sbncode#671develop] [3/4] icarusalg#102develop] [4/4] #922 (for listing completeness)Reviewers: