chore: drop Python 3.9 support, raise minimum to 3.10 - #306
Merged
Merged
Conversation
phanak-sap
commented
Jul 6, 2026
phanak-sap
commented
Contributor
- Remove 3.9 from CI matrix; drop lxml 4.3.5/4.4.3/4.5.2 (3.9-only) and their now-redundant 3.10 excludes
- Add python_requires='>=3.10' to setup.py; remove 3.9 classifier
- Update README requirement from 3.9 to 3.10
- Add CHANGELOG Removed entry for 3.9 drop
- Replace deprecated typing.ByteString with bytes in test_vendor_sap.py
- Remove 3.9 from CI matrix; drop lxml 4.3.5/4.4.3/4.5.2 (3.9-only) and their now-redundant 3.10 excludes - Add python_requires='>=3.10' to setup.py; remove 3.9 classifier - Update README requirement from 3.9 to 3.10 - Add CHANGELOG Removed entry for 3.9 drop - Replace deprecated typing.ByteString with bytes in test_vendor_sap.py
Contributor
Author
|
this one closes #301 |
filak-sap
approved these changes
Jul 8, 2026
filak-sap
pushed a commit
that referenced
this pull request
Sep 22, 2026
Python 3.10 is the minimum since #306, so the two-argument form of super() that Python 2 needed is noise in every subclass initializer. Replace all 41 occurrences in exceptions.py, v2/model.py, v2/service.py and vendor/SAP.py with the zero-argument form. Each replacement was checked against the enclosing class: the name passed to super() was the class being defined in every case, so no call was deliberately skipping a level of the MRO and behaviour is unchanged. The one continuation line that no longer lined up with its opening parenthesis was re-indented. No test is added because no behaviour changes; the existing suite covers every touched initializer. Part of #302. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.