Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/platform/macos/context.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ use dispatch2::MainThreadBound;
use objc2::rc::Weak;
use objc2::runtime::NSObjectProtocol;
use objc2::{MainThreadMarker, Message};
use objc2_app_kit::NSCursor;
use raw_window_handle::DisplayHandle;
use std::rc::Rc;

Expand Down Expand Up @@ -75,7 +76,11 @@ impl WindowContext {
pub fn set_mouse_cursor(&self, cursor: MouseCursor) -> Result<()> {
let Some(view) = self.view.load() else { return Ok(()) };
let native_cursor = Cursor::from(cursor);
view.addCursorRect_cursor(view.bounds(), &native_cursor.load());
if let Some(cursor) = native_cursor.load() {
view.addCursorRect_cursor(view.bounds(), &cursor);
} else {
NSCursor::hide()
}
Ok(())
}

Expand Down
19 changes: 10 additions & 9 deletions src/platform/macos/cursor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ use crate::MouseCursor;
pub enum Cursor {
Native(fn() -> Retained<NSCursor>),
Undocumented(Sel),
Hidden,
}

impl From<MouseCursor> for Cursor {
Expand Down Expand Up @@ -55,34 +56,34 @@ impl From<MouseCursor> for Cursor {
Cursor::Undocumented(sel!(busyButClickableCursor))
}

_ => Cursor::Native(NSCursor::arrowCursor),
// MouseCursor::Hidden => todo!(),
// MouseCursor::Move => todo!(),
// MouseCursor::AllScroll => todo!(),
// MouseCursor::Cell => todo!(),
MouseCursor::Move => Cursor::Native(NSCursor::arrowCursor),
MouseCursor::AllScroll => Cursor::Native(NSCursor::arrowCursor),
MouseCursor::Cell => Cursor::Native(NSCursor::crosshairCursor),
MouseCursor::Hidden => Cursor::Hidden,
}
}
}

impl Cursor {
pub fn load(&self) -> Retained<NSCursor> {
pub fn load(&self) -> Option<Retained<NSCursor>> {
match self {
Cursor::Native(loader) => loader(),
Cursor::Native(loader) => Some(loader()),
Cursor::Undocumented(sel) => {
let class = NSCursor::class();

// NOTE: class.responds_to does not yield the same result (probably because NSCursor overrides respondsToSelector)
let responds_to: bool = unsafe { msg_send![class, respondsToSelector: *sel] };

if !responds_to {
return NSCursor::arrowCursor();
return Some(NSCursor::arrowCursor());
}

let raw: *mut NSCursor = unsafe { class.send_message(*sel, ()) };
let cursor = unsafe { Retained::retain(raw) };

cursor.unwrap_or_else(NSCursor::arrowCursor)
Some(cursor.unwrap_or_else(NSCursor::arrowCursor))
}
Cursor::Hidden => None,
}
}
}
7 changes: 5 additions & 2 deletions src/platform/macos/view.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ use objc2::rc::Weak;
use objc2::runtime::{NSObjectProtocol, ProtocolObject};
use objc2::{msg_send, AllocAnyThread, ClassType, MainThreadMarker};
use objc2_app_kit::{
NSApplication, NSDragOperation, NSDraggingInfo, NSEvent, NSFilenamesPboardType, NSTrackingArea,
NSTrackingAreaOptions, NSView, NSWindow,
NSApplication, NSCursor, NSDragOperation, NSDraggingInfo, NSEvent, NSFilenamesPboardType,
NSTrackingArea, NSTrackingAreaOptions, NSView, NSWindow,
};
use objc2_foundation::{NSArray, NSNotification, NSPoint, NSRect, NSSize, NSString};
use std::cell::{Cell, RefCell};
Expand Down Expand Up @@ -274,6 +274,9 @@ impl BaseviewView {
impl Drop for BaseviewView {
fn drop(&mut self) {
self.state.closed.set(true);
if self.state.cursor_hidden.get() {
NSCursor::unhide();
}
}
}

Expand Down
2 changes: 2 additions & 0 deletions src/platform/macos/window.rs
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ pub(crate) struct WindowSharedState {
pub size: Cell<LogicalSize<f64>>,
pub scale_factor: Cell<f64>,
pub sizing_strategy: SizingStrategy,
pub cursor_hidden: Cell<bool>,
}

impl WindowSharedState {
Expand All @@ -189,6 +190,7 @@ impl WindowSharedState {
size: size.into(),
scale_factor: scale_factor.into(),
sizing_strategy,
cursor_hidden: false.into(),
}
}
}
Expand Down