add cargo-gpu generate - #568
Conversation
f4f77a8 to
e6ca8c5
Compare
LegNeato
left a comment
There was a problem hiding this comment.
Wait, we have cargo-gpu, spirvbuilder, and cargo-gpu-install?!?! That seems really bad and confusing.
Can't we just put this behind an off-by-default flag (looks like it is on?) that is turned on for the binary? That way people using cargo-gpu in teh build script don't get changes in behavior and we still get this feature.
So I guess I don't see why cargo-gpu-install even exists?
No we can't, cause if you So our only option was to split the crate in two, a library crate for build scripts ( For additional background:
|
|
Ahhh, I see. Thanks for explaining. |
e6ca8c5 to
ca3e4ed
Compare
ca3e4ed to
516da11
Compare
d83cabf to
7260147
Compare
|
@LegNeato can you rereview this one? |
7260147 to
aa0c1f6
Compare
aa0c1f6 to
5f81246
Compare
cargo-gpu generateeffectively aliasescargo generatewith the rust-gpu-template repocargo-gpudepend oncargo-generate, which significantly increases the amount of dependenciescargo-gpuhas. I expect most users to migrate tocargo-gpu-installfor their build script needs.cargo-gpuas a dep, I've madecargo-generatea default feature you can disablecargo generatealso depends on quite a few outdated packages, including vulnerabilities, making ourcargo denycomplain. I've made it pass by ignoring them all, as I don't think there's a huge concern for a dev cmdline tool.close #576