Fix CodeTailor question lookup failing in cloned courses - #1450
Open
aspadiyath wants to merge 1 commit into
Open
Fix CodeTailor question lookup failing in cloned courses#1450aspadiyath wants to merge 1 commit into
aspadiyath wants to merge 1 commit into
Conversation
parsons_scaffolding resolved the activecode's question row with fetch_question(problem_id, basecourse=course.base_course). A cloned course keeps the original book's base_course on its question rows, and selectquestion can pull an exercise from another book, so that base-course-scoped lookup returns nothing and the endpoint 400s with "question '<id>' not found" -- the student's "get help" button is dead. Fall back to a global name match (fetch_question(problem_id) with no basecourse) when the scoped lookup misses, the same resolution get_question_source and /htmlsrc already use. The scoped lookup still runs first so the single-book case is unchanged, and a warning is logged when the fallback fires so a genuine duplicate div_id across books stays diagnosable. The validated test case still comes from the resolved DB row -- no client-supplied code path. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parsons_scaffolding resolved the activecode's question row with fetch_question(problem_id, basecourse=course.base_course). A cloned course keeps the original book's base_course on its question rows, and selectquestion can pull an exercise from another book, so that base-course-scoped lookup returns nothing and the endpoint 400s with "question '' not found" -- the student's "get help" button is dead.
Fall back to a global name match (fetch_question(problem_id) with no basecourse) when the scoped lookup misses, the same resolution get_question_source and /htmlsrc already use. The scoped lookup still runs first so the single-book case is unchanged, and a warning is logged when the fallback fires so a genuine duplicate div_id across books stays diagnosable.