-
-
Notifications
You must be signed in to change notification settings - Fork 276
Creation of the magnetometer sensor #1190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aitorperezgrau-sys
wants to merge
95
commits into
RocketPy-Team:develop
Choose a base branch
from
aitorperezgrau-sys:ENH/creation-magnetometer
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
95 commits
Select commit
Hold shift + click to select a range
d3f2e85
add add_wire method, Magnetometer class and Wire class
aitorperezgrau-sys e393345
improvements of wire Class, magnetometer Class and add_wire
aitorperezgrau-sys dc91b27
importing adjustments
aitorperezgrau-sys 86af66a
importing adjustments
aitorperezgrau-sys 9914c0b
changes in importing
aitorperezgrau-sys 454fb11
improvementof magnetometer class with the introduction of some attrib…
aitorperezgrau-sys 96c4c53
changes on the strucuture of Wire and Magnetomter to allow the same w…
aitorperezgrau-sys 2854931
many changes
aitorperezgrau-sys 7fac64f
definition of the calculation of magnetic field, as well as in sensor…
aitorperezgrau-sys cffafd1
copy
aitorperezgrau-sys f0b3107
many chagnges
aitorperezgrau-sys 1bf8dbb
typos errors checked
aitorperezgrau-sys 94594ce
allowing the HIL version of the Wire, by means of lazy validation of …
aitorperezgrau-sys e8d329d
documentation changes, and naming improvements
aitorperezgrau-sys 536d1da
creation of plate class, add_plate, changes in wire functions and mag…
aitorperezgrau-sys f9f427f
commencement of the obtainment of the soft iron matrix
aitorperezgrau-sys 6ad3035
improvemet of the plate class, as well as the definition of radius fu…
aitorperezgrau-sys 69a7dd3
improvement of plate class, as welll as add_plate, magnetometer and s…
aitorperezgrau-sys b9c8950
improvements
aitorperezgrau-sys 903deab
improvement on the soft iron distortion matrix
aitorperezgrau-sys 2e3b8d0
improvements on point class and tests
aitorperezgrau-sys 3ddaa16
improvements on plate soft iron distortion matrix calculations, and t…
aitorperezgrau-sys 4187cee
improving the plate calculation of the soft iron distortion matrix, a…
aitorperezgrau-sys 303d97e
changes in style adn documentation
aitorperezgrau-sys 5b9c1d1
improvements in the documentation
aitorperezgrau-sys 7e95229
elimination of current direciton attribute, creation of inside rocket…
aitorperezgrau-sys 6469bc3
improvemetn of the plate generate_points funciton
aitorperezgrau-sys fa47060
improvements and tests
aitorperezgrau-sys 85ad534
reorganization and generalization and refinement of motor ignition co…
aitorperezgrau-sys ec29728
changes in documentation and magnetometer calculations frame
aitorperezgrau-sys d09404a
improvements in precision and readibility
aitorperezgrau-sys 0823c82
creation of plots and prints of plate class
aitorperezgrau-sys 7a92f35
introduction of the prints and plots of the Wire and Plate classes, t…
aitorperezgrau-sys 310911d
improvements on plots and prints
aitorperezgrau-sys 1462e6b
improvemetn of documentation and precision
aitorperezgrau-sys 409a482
improvemetn of the documentation, improvemetn of the plate class para…
aitorperezgrau-sys e551dcb
documentation changes and change in the operations of the magnetometer
aitorperezgrau-sys aafadee
chagnes in coordinates and plots
aitorperezgrau-sys 5d30bf6
improvements on coordinate system definition, and plots
aitorperezgrau-sys 00203b8
introduction of the user frame in the plots, and improvemetn of the g…
aitorperezgrau-sys 6262378
changes in documentation and style
aitorperezgrau-sys 94ee39d
improvement of the documentation, and changes in validation of input …
aitorperezgrau-sys 9053270
begging of tests for implemented classes adn funcitons, and several c…
aitorperezgrau-sys cc7cb25
tests in rocket , plate and wire
aitorperezgrau-sys 6abe12a
continuation of testing
aitorperezgrau-sys 2cf3c68
test_plate and changes on plate and plate_plot to properly characteri…
aitorperezgrau-sys fb01fde
all unit test done
aitorperezgrau-sys b648730
continue doing the testing work
aitorperezgrau-sys caf4a48
continuation of testing
aitorperezgrau-sys 2718f25
test_sensor
aitorperezgrau-sys bc9ce57
test and changes on data strucutres
aitorperezgrau-sys 7b58ea5
improving wire class as well as test_wire and magnetometer class
aitorperezgrau-sys d7966df
created the documentation and testing
aitorperezgrau-sys 7a68281
addition to the documentation of the new classes
aitorperezgrau-sys 0d2ecd2
index chagnes to include plate and wire plots and prints
aitorperezgrau-sys 1de6a6c
improvement of documentation and adjustmetn of requirements file to s…
aitorperezgrau-sys ed6fa0b
changes and improvements in the documentation, both docstrigns and .r…
aitorperezgrau-sys 7bf67d0
more on documentation
aitorperezgrau-sys 4a6233b
hiding the private validation methods
aitorperezgrau-sys a7078ca
more improvements
aitorperezgrau-sys 352d029
improvements
aitorperezgrau-sys ed54f14
changes in docstirng
aitorperezgrau-sys 1798d24
changes on docstrings to ommit redundancy
aitorperezgrau-sys 132587c
more on documentation
aitorperezgrau-sys c11d803
a
aitorperezgrau-sys 3b7f4bb
changes on the strucutre of plate validation, allowing rectangular sh…
aitorperezgrau-sys c5c3b79
improving plots
aitorperezgrau-sys 40d56c7
a
aitorperezgrau-sys 1c45a33
eliminating auxiliary file
aitorperezgrau-sys 2b5c8b5
changes on documentation
aitorperezgrau-sys 9d0b9bc
format
aitorperezgrau-sys 25b1fff
improvements in docstring
aitorperezgrau-sys 0ab2c59
improvement of docstirng
aitorperezgrau-sys face5a4
a
aitorperezgrau-sys e71af87
docstring changes
aitorperezgrau-sys e852ef3
sublte docstring changes
aitorperezgrau-sys ddcbc37
a
aitorperezgrau-sys 22217c4
swap ValueError by InvalidParameterError, which has been generalized …
aitorperezgrau-sys 15586e5
changes on test due to name changes
aitorperezgrau-sys 4e9ec49
test subtle change due to name
aitorperezgrau-sys d27131f
creation of csys and center of dry mass attirbutes to have a more cle…
aitorperezgrau-sys a4e01b5
format, and some minor test chagnes due to previus code changes
aitorperezgrau-sys a06a8e1
changes due to name changes
aitorperezgrau-sys a278192
changes in docstrings
aitorperezgrau-sys 3888331
changeso on testwire dosctribg
aitorperezgrau-sys e4f598a
formats changes
aitorperezgrau-sys 95c38c9
elimination of reimported plate
aitorperezgrau-sys 4d755d2
importing adjustments
aitorperezgrau-sys 29face7
outputs of pytest generated automatically and related to montecarlo
aitorperezgrau-sys de3b4a7
remove auto-generated monte carlo test
aitorperezgrau-sys f10d656
Merge remote-tracking branch 'origin/develop' into pr1190-fixes
Gui-FernandesBR ee2332b
BUG: fix the magnetometer's integration with Flight and its lifecycle
Gui-FernandesBR c3cfe22
Merge remote-tracking branch 'origin/develop' into pr1190-fixes
Gui-FernandesBR 27ce7e0
MNT: keep PR #1190 to its own scope and green on the linters
Gui-FernandesBR b519211
Merge remote-tracking branch 'origin/develop' into pr1190-fixes
Gui-FernandesBR File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Plate Class | ||
| ------------ | ||
|
|
||
| .. autoclass:: rocketpy.Plate | ||
| :members: | ||
| :exclude-members: from_dict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Wire Class | ||
| ------------ | ||
|
|
||
| .. autoclass:: rocketpy.Wire | ||
| :members: | ||
| :exclude-members: from_dict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Magnetometer Class | ||
| ------------------ | ||
|
|
||
| .. autoclass:: rocketpy.sensors.Magnetometer | ||
| :members: | ||
| :exclude-members: from_dict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| Plate Plots Class | ||
| ------------------- | ||
|
|
||
| .. autoclass:: rocketpy.plots.plate_plots._PlatePlots | ||
| :members: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| Plate Prints Class | ||
| ------------------- | ||
|
|
||
| .. autoclass:: rocketpy.prints.plate_prints._PlatePrints | ||
| :members: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| Plate Plots and Prints Classes | ||
| =============================== | ||
|
|
||
| .. toctree:: | ||
| :maxdepth: 1 | ||
| :caption: Contents: | ||
|
|
||
| PlatePlots | ||
| PlatePrints |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| Wire Plots Class | ||
| ------------------- | ||
|
|
||
| .. autoclass:: rocketpy.plots.wire_plots._WirePlots | ||
| :members: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| Wire Prints Class | ||
| ------------------- | ||
|
|
||
| .. autoclass:: rocketpy.prints.wire_prints._WirePrints | ||
| :members: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| Wire Plots and Prints Classes | ||
| =============================== | ||
|
|
||
| .. toctree:: | ||
| :maxdepth: 1 | ||
| :caption: Contents: | ||
|
|
||
| WirePlots | ||
| WirePrints |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,3 +6,4 @@ requests | |
| pytz | ||
| simplekml | ||
| dill | ||
| pywmm>=1.1.1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e and plates? what do those mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In rockets, magnetometers face three magnetic distortions beyond the sensor's intrinsic limitations. These are
Soft iron distortion: caused by materials with higher magnetic permeability than vacuum. As a result, the magnetic field lines are forced to pass through these materials, altering the magnetic reading. To account for this magnetic distortion, I created the
Plateclass, which simulates a material sheet that is responsible for this bending of the magnetic field lines.Power interference: caused by wires in the avionics bay, which, due to current flow, generate a magnetic field, affecting the magnetic field reading. The power interference is, in turn, divided into communication interference, which comprises the magnetic field generated by wires with constant electron flow; and activation signal interference, which includes only the magnetic field generated by wires which fulfill some activation/pyrotechnic function (such as the one that activates the engine, or the one used to deploy the parachute). To account for this power interference, I created the
Wireclass.Hard iron distortion: caused by fixed components in the avionics bay, and it is simulated by a vector addition.
There is additional information about the formulation and usage of the
WireandPlateclasses in the PR description and in their docstrings, let me know if you have more questions or if you would like me to clarify something.