Fix #70: anchor the screen-capture device match - #77
Merged
Conversation
selectDevices picked the screen by an unanchored strings.Contains with first-match-wins, and avfoundation lists cameras before screen pseudo-devices — so a camera whose OS-supplied name merely contained "Capture screen" (crafted, or a vendor string) shadowed the genuine display and was recorded into screen.mp4 silently. Match the anchored canonical form ^Capture screen \d+$ instead: the video-side sibling of the microphone's :default anti-shadowing hardening. Fixes #70. Assisted-by: Claude:claude-fable-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validated against main:
selectDevicesused an unanchoredstrings.Contains(d.name, "Capture screen")withbreak, and the repo's own fixture ordering puts cameras before the screen device (regression test added first — fails on main selecting the lookalike camera at index 0).Fix: match the anchored canonical
^Capture screen \d+$via a documentedscreenDeviceregex, so only the genuine macOS screen pseudo-device can resolve. CHANGELOG entry added.Fixes #70