Fix #69: emitted request escapes inline Markdown in manifest fields - #76
Merged
Conversation
EmitRequest rendered App, Participant, and Tasks through session.SafeText only, which deliberately passes the inline-Markdown triggers through, and the three fields sit as list items outside any code fence — so an attacker-authored manifest value survived as a live link or image beacon in a saved request.md, the exact construct report.md already neutralises for the identical fields. Hoist the escape into session.SafeInline as the one shared home (one-canonical-primitive), delegate report's mdInline to it, and route the emit fields through it. The false 'matching report' parity claim in EmitRequest's comment is corrected. Fixes #69. Assisted-by: Claude:claude-fable-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validated against main:
EmitRequestrenders App/Participant/Tasks withSafeTextonly, outside any fence (regression test added first — fails on main with the beacon link surviving verbatim).Fix: hoist the escape set into
session.SafeInline— one canonical home — withreport.mdInlinedelegating to it andemit.go's three fields routed through it, so the two Markdown artefacts built from untrusted manifest text cannot drift. Corrects the comment whose 'matching report' parity claim the issue showed to be false. CHANGELOG entry added.Fixes #69